Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Unhandled error when background fetching flags #138

Merged
merged 1 commit into from
Dec 18, 2023
Merged

fix: Unhandled error when background fetching flags #138

merged 1 commit into from
Dec 18, 2023

Conversation

benjackwhite
Copy link
Collaborator

Problem

Reported issues where failing API requests can crash the process (see here)

Changes

Don't throw but rather report up to the emitter

Release info Sub-libraries affected

Bump level

  • Major
  • Minor
  • Patch

Libraries affected

  • All of them
  • posthog-web
  • posthog-node
  • posthog-react-native

@jurajmajerik
Copy link

Thanks @benjackwhite 👍

cc @neilkakkar

liyiy
liyiy approved these changes Dec 15, 2023
View reviewed changes
Copy link
Contributor

@liyiy liyiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ty !

@benjackwhite benjackwhite merged commit 5e6b427 into master Dec 18, 2023
3 checks passed
@benjackwhite benjackwhite deleted the fix/error-handling branch December 18, 2023 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liyiy liyiy liyiy approved these changes

@jurajmajerik jurajmajerik jurajmajerik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benjackwhite @jurajmajerik @liyiy