Add prerelease string when NormalizedVersion doesn't exist (but prelease string does)

[sean-r-williams]

PR Summary

This PR conditionally adds the package prerelease string to the to-be-installed package version name (passed to InstallVersion()) inside InstallHelper.BeginPackageInstall()

PR Context

Currently, the version string is backfilled with the package's raw Version field if NormalizedVersion was not returned by the package management service. This causes a difference in behavior:

• For sources that provide NormalizedVersion, the prerelease string is included in NormalizedVersion and is included in pkgVersion as a result.
• For sources that don't provide it, System.Version does not include prerelease info and as-such the prerelease string is not included in pkgVersion.

This PR reconciles the second case to include prerelease strings, aligning it with the first.

Fixes #1680.

Concerns

I don't have visibility into NormalizedVersion behavior on other package management services (only Artifactory and PSGallery), so I'm not 100% sure if pkgToInstall.Prerelease is the correct field to rely on.

PR Checklist

• PR has a meaningful title
  • Use the present tense and imperative mood when describing your changes
• Summarized changes
• Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
• This PR is ready to merge and is not Work in Progress.
  • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
• Breaking changes
  • None
  • OR
  • Documentation needed
    • Issue filed:
• User-facing changes
  • Not Applicable
  • OR
  • Documentation needed
    • Issue filed:
• Testing - New and feature
  • N/A or can only be tested interactively
  • OR
  • Make sure you've added a new test if existing tests do not effectively test the code changed
• Tooling
  • I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
  • OR
  • I have considered the user experience from a tooling perspective and enumerated concerns in the summary.

[alerickson]

Thanks @sean-r-williams! The PR looks good, pkgToInstall.Prerelease is the correct field to rely on. Could you add a comment related to why you're fixing this to help prevent regression until we can get proper Artifactory tests in place?

[sean-r-williams]

@alerickson I added a comment in e05bbef.

I want to double-click on the context here: This should impact any NuGet provider where NormalizedVersion isn't sent. (The PR where these lines were last changed mentioned ACR - does ACR send NormalizedVersion?) Artifactory is an example of this (and Artifactory integration tests would've caught it, sure) but I don't think they're unique in that regard.

[alerickson]

@sean-r-williams, yup that makes sense, I just haven't been able to replicate in an environment that we have tests for at the moment.

[alerickson]

/azp

[azure-pipelines]

Supported commands

• help:
• Get descriptions, examples and documentation about supported commands
• Example: help "command_name"
• list:
• List all pipelines for this repository using a comment.
• Example: "list"
• run:
• Run all pipelines or specific pipelines for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify specific pipelines to run.
• Example: "run" or "run pipeline_name, pipeline_name, pipeline_name"
• where:
• Report back the Azure DevOps orgs that are related to this repository and org
• Example: "where"

See additional documentation.

[alerickson]

/azp run PowerShell.PSResourceGet

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).