Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(AnimeLib): change activity styling #9127

Merged
merged 2 commits into from
Jan 9, 2025
Merged

Conversation

Kitosight
Copy link
Contributor

feat(AnimeLib): privacy mode for 'collections' case

feat(AnimeLib): add collection type in 'collections' case

Collection type is shown in the details and follows this format: "Коллекция по " (" collection")

feat(AnimeLib): add placeholder for unavailability to display info when watching a licensed anime

fix(AnimeLib): fail to get current episode number in specific window size

Description

Acknowledgements

Screenshots

Proof showing the creation/modification is working as expected

style(AnimeLib): change activity styling
feat(AnimeLib): add collection type in 'collections' case
image
image
image
image

feat(AnimeLib): add placeholder for unavailability to display info when watching a licensed anime
image
image

feat(AnimeLib): privacy mode for 'collections' case

feat(AnimeLib): add collection type in 'collections' case

Collection type is shown in the details and follows this format: "Коллекция по <type>" ("<type> collection")

feat(AnimeLib): add placeholder for unavailability to display info when watching a licensed anime

fix(AnimeLib): fail to get current episode number in specific window size
Copy link
Member

@Bas950 Bas950 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest LGTM

websites/A/AnimeLib/presence.ts Show resolved Hide resolved
theusaf
theusaf previously approved these changes Jan 8, 2025
@theusaf theusaf requested a review from Bas950 January 8, 2025 23:41
@theusaf theusaf enabled auto-merge (squash) January 8, 2025 23:41
@Kitosight Kitosight marked this pull request as draft January 9, 2025 02:00
auto-merge was automatically disabled January 9, 2025 02:00

Pull request was converted to draft

fix(AnimeLib): crash when 'rus_name' is empty string

Replaces with 'name' as it is always present
@Kitosight Kitosight marked this pull request as ready for review January 9, 2025 02:51
@Kitosight Kitosight requested a review from theusaf January 9, 2025 02:52
@Bas950 Bas950 dismissed theusaf’s stale review January 9, 2025 11:17

Changes were made

@Bas950 Bas950 enabled auto-merge (squash) January 9, 2025 11:17
@Bas950 Bas950 merged commit eacbde2 into PreMiD:main Jan 9, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants