Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Granblue Fantasy): handle no alive boss #9128

Merged
merged 1 commit into from
Jan 8, 2025
Merged

fix(Granblue Fantasy): handle no alive boss #9128

merged 1 commit into from
Jan 8, 2025

Conversation

kyrie25
Copy link
Contributor

@kyrie25 kyrie25 commented Jan 8, 2025 •
edited
Loading

Description

  • Get the highest Max HP boss of the stage (aka. the actual "boss")
  • Handle not being able to find "alive" bosses when stage is cleared and user does not move to results page, making the concatenation of activity state undefined | Turn x

Acknowledgements

Screenshots

Proof showing the creation/modification is working as expected

image

@Bas950 Bas950 enabled auto-merge (squash) January 8, 2025 15:41
@Bas950 Bas950 requested a review from theusaf January 8, 2025 15:41
@Bas950 Bas950 merged commit 68337f6 into PreMiD:main Jan 8, 2025
3 checks passed
@kyrie25 kyrie25 deleted the fix/gbf-boss-hp branch January 8, 2025 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bas950 Bas950 Bas950 approved these changes

@theusaf theusaf theusaf approved these changes

Assignees
No one assigned
Labels
activity update
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kyrie25 @theusaf @Bas950