Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Multistore list block #613

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Feature: Multistore list block #613

wants to merge 2 commits into from

Conversation

Triloworld
Copy link

Add id_shop for multishop purpouse

Questions Answers
Description? Please be specific when describing this change. What did you change? Why?
Type? bug fix / improvement
BC breaks? yes / no - propably yes but need investgation
Deprecations? no
Fixed ticket? PrestaShop/PrestaShop#29219
Sponsor company Webo.agency
How to test? Enable multistore. Add block for one store. Change store and add another block with same language. Have different text for different store in same language. Check homepage - should display all blocks and don't have difference in context of choosen shop. Apply this pull-request - see fever blocks that exist only in one id_shop context which is what you expect

@Triloworld
Add is_shop context to sql query
357492c 
Add id_shop for multishop purpouse
nicosomb
nicosomb requested changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@nicosomb nicosomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To fix php cs error.

classes/ReassuranceActivity.php Outdated Show resolved Hide resolved
Triloworld
Triloworld commented Oct 30, 2023
View reviewed changes
Copy link
Author

@Triloworld Triloworld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

php cs errors resolve

classes/ReassuranceActivity.php Outdated Show resolved Hide resolved
Triloworld
Triloworld commented Oct 30, 2023
View reviewed changes
Copy link
Author

@Triloworld Triloworld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

php cs fix

leemyongpakvn
leemyongpakvn suggested changes Oct 31, 2023
View reviewed changes
classes/ReassuranceActivity.php
$sql = 'SELECT * FROM `' . _DB_PREFIX_ . 'psreassurance` pr
LEFT JOIN ' . _DB_PREFIX_ . 'psreassurance_lang prl ON (pr.id_psreassurance = prl.id_psreassurance)
WHERE prl.id_lang = "' . (int) $id_lang . '"
AND prl.id_shop = "' . (int) $id_shop . '"
Copy link
Contributor

@leemyongpakvn leemyongpakvn Oct 31, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is just a small part of what PR 336 - Remove broken multishop support removed since March 2022. If we dive deeper in that PR changes, we can see to bring this line back we need to bring its prerequisite line back too.
For a whole view to make sure we won't bring an old feature back with known issues, I suggest reading the whole PR336 changes and conversation.

@ps-jarvis ps-jarvis added the waiting for author Status: Waiting for Author Feedback label Oct 31, 2023
@matthieu-rolland matthieu-rolland added this to the 5.1.5 milestone Nov 8, 2023
@leemyongpakvn leemyongpakvn modified the milestones: 5.1.5, 6.0.0 Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leemyongpakvn leemyongpakvn leemyongpakvn requested changes

@nicosomb nicosomb nicosomb requested changes

Assignees
No one assigned
Labels
waiting for author Status: Waiting for Author Feedback
Projects
PR Dashboard
Status: Ready for review
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@Triloworld @nicosomb @leemyongpakvn @matthieu-rolland @ps-jarvis