Ajax failing in decorating controller. #1008
Conversation
Rho-bur
commented
May 21, 2021
Rho-bur
commented
| Questions | Answers |
|---|---|
| Description? | Ajax failing in decorating controller; mention regarding the need to implement all the Actions methods of the decorated controller. |
| Fixed ticket? | Fixes #{issue number here} if there is a related issue |
… the need of implementing the decorated controller action methods
Ajax calls not working with decorated controllers; mention to clarify the need of implementing the decorated controller action methods
Update override-decorate-controller.md
…plement the decorated controller action methods
|
|
||
| On some edge cases we might need to perform an Ajax call from our Javascript file (or the Twig template) to our decorating DemoController. | ||
| Curently this will not work though, what we need to do in such a case is to create a regular admincontroller e.g. mymodule/src/Controller/Admin/DemoAjaxController.php with a method, create a route for that method in our mymodule/src/config/routes.yml, generate the URL as described here, [symfony docs](https://devdocs.prestashop.com/1.7/modules/concepts/controllers/admin-controllers/route-generation/) and perform our ajax call using the resulting Symfony route. | ||
| <<<<<<< HEAD |
There was a problem hiding this comment.
Hello I think this was not wanted 😉 ?
| ``` | ||
|
|
||
| On some edge cases we might need to perform an Ajax call from our Javascript file (or the Twig template) to our decorating DemoController. | ||
| Curently this will not work though, what we need to do in such a case is to create a regular admincontroller e.g. mymodule/src/Controller/Admin/DemoAjaxController.php with a method, create a route for that method in our mymodule/src/config/routes.yml, generate the URL as described here, [symfony docs](https://devdocs.prestashop.com/1.7/modules/concepts/controllers/admin-controllers/route-generation/) and perform our ajax call using the resulting Symfony route. |
There was a problem hiding this comment.
Hello, this sounds like a bug 😄 actually. Can you tell me more? Would you have a code sample I could analyze?
There was a problem hiding this comment.
Hi,
I'll attach the files here as the repository is private.
Ajax does not work in the decorating RmvProductController but works on AdminActionsController.
Routes in main class:
Media::addJsDef([ 'admin_products_url' => $this->context->link->getAdminLink('AdminRmvActions'), 'symfonyUrl' => $this->context->link->getAdminLink('RmvProduct', true, array('route' => 'rmvpreciousmetals_rmv_unit')), 'adminCommandUrl' => $this->context->link->getAdminLink('AdminActions', true, array('route' => 'rmvpreciousmetals_run_command')), ]);
routes.yml:
rmvpreciousmetals_rmv_unit:
path: rmvpreciousmetals/update-product
methods: [POST]
defaults:
_controller: 'PrestaShop\Module\RmvPreciousMetals\Controller\Admin\AdminActionsController::setProductPricesAction'
_legacy_controller: AdminActions
rmvpreciousmetals_run_command:
path: rmvpreciousmetals/run-product
methods: [GET|POST]
defaults:
_controller: 'PrestaShop\Module\RmvPreciousMetals\Controller\Admin\AdminActionsController::sendApiRequest'
_legacy_controller: AdminActions
When using the RmvProductController action (a new action not from the decoratedController) in the rmvpreciousmetals_rmv_unit path the ajax does not work, switching it to a regular controller not decorating anything (AdminActionsController) works.
Here is the slack thread I have opened for this, slack
There was a problem hiding this comment.
If you think seeing the full code will help I could grant you access to my private repo, no problem.
There was a problem hiding this comment.
Sorry for late answer, week has been very busy I did not have time to explore the topic
There was a problem hiding this comment.
I understand, no worries, I'll wait!
| public function anAction($id, Request $request) | ||
| { | ||
| return $this->decoratedController->anAction($id, $request); | ||
| } |
There was a problem hiding this comment.
| public function anAction($id, Request $request) | |
| { | |
| return $this->decoratedController->anAction($id, $request); | |
| } | |
| public function anAction($id, Request $request) | |
| { | |
| return $this->decoratedController->anAction($id, $request); | |
| } |
|
@thomasnares let's try cherry pick this PR for v8 and finish it 👍🏻 |
