chore: setup tests

PrestaShopCorp · Dec 19, 2024 · b914263 · b914263
1 parent 254d568
commit b914263
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 16 deletions.
diff --git a/src/ServiceContainer/ServiceContainer.php b/src/ServiceContainer/ServiceContainer.php
@@ -63,20 +63,6 @@ public function __construct($configPath)
         $this->configPath = $configPath;
     }
 
-    /**
-     * @param string $configPath
-     *
-     * @return static
-     */
-    public static function createInstance($configPath)
-    {
-        $container = new static($configPath);
-        $container->loadConfig();
-        $container->init();
-
-        return $container;
-    }
-
     /**
      * @return void
      */
@@ -91,10 +77,12 @@ public function loadConfig()
     abstract public function getLogger();
 
     /**
-     * @return void
+     * @return ServiceContainer
      */
     public function init()
     {
+        $this->loadConfig();
+
         $this->getLogger()->debug('Initializing service container');
 
         foreach ($this->provides as $provider) {
@@ -104,6 +92,8 @@ public function init()
                 (new $provider())->provide($this);
             }
         }
+
+        return $this;
     }
 
     /**

diff --git a/tests/src/ServiceContainer/ServiceContainerTest.php b/tests/src/ServiceContainer/ServiceContainerTest.php
@@ -24,7 +24,7 @@ class ServiceContainerTest extends TestCase
 
     public function setUp(): void
     {
-        $this->container = TestServiceContainer::createInstance(__DIR__ . '/config.php');
+        $this->container = (new TestServiceContainer(__DIR__ . '/config.php'))->init();
     }
 
     /**
-Original file line number
+Diff line change
@@ Expand Up / @@ -24,7 +24,7 @@ class ServiceContainerTest extends TestCase @@
         public function setUp(): void
         {
-            $this->container = TestServiceContainer::createInstance(__DIR__ . '/config.php');
+            $this->container = (new TestServiceContainer(__DIR__ . '/config.php'))->init();
         }
         /**
@@ Expand Down @@