Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make live reco send blocking #160

Merged
merged 1 commit into from
Nov 14, 2024
Merged

make live reco send blocking #160

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/zeroband/checkpoint.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -546,7 +546,7 @@ def recv_ckpt_from_peer(self, global_pg: dist.ProcessGroup):
)

@torch.no_grad()
def send_ckpt_to_peer(self, global_pg: dist.ProcessGroup, dest_rank: int):
def send_ckpt_to_peer(self, global_pg: dist.ProcessGroup, dest_rank: int, blocking: bool = False):
def async_send():
assert self.diloco_offloaded_param_list is not None, "send_ckpt_to_peers is only supported with diloco"
time_start = time.perf_counter()
Expand Down Expand Up @@ -582,8 +582,10 @@ def async_send():
thread = threading.Thread(target=async_send)
thread.start()
self._logger.debug("Live recovery thread started")

self._live_reco_thread = thread
if blocking:
thread.join()
else:
self._live_reco_thread = thread


def delete_topk(ckpt_path: str, topk: int):
Expand Down
2 changes: 1 addition & 1 deletion src/zeroband/train.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,7 @@ def train(config: Config):
)
logger.info(f"inner optimizer hash: {get_optimizer_signature(inner_optimizer)}")

ckpt_manager.send_ckpt_to_peer(elastic_device_mesh.global_pg, maybe_dest_rank)
ckpt_manager.send_ckpt_to_peer(elastic_device_mesh.global_pg, maybe_dest_rank, blocking=True)

elastic_device_mesh.live_recovery.reset()
else:
Expand Down