Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change diloco script to not have tail blocking #185

Merged
merged 1 commit into from
Jan 7, 2025
Merged

change diloco script to not have tail blocking #185

merged 1 commit into from
Jan 7, 2025

Conversation

samsja
Copy link
Collaborator

@samsja samsja commented Jan 7, 2025

previously it was not possible to chain two calls to our diloco helper script because the tail was blocking. This pr fix this. Making it easy to run multiple experiments in one go.

Example of what was failing before

#!/bin/bash

for i in {1..3}; do
    ./scripts/simulate_multi_node_diloco.sh 2 2 src/zeroband/train.py @ configs/debug/normal.toml
done

This would stay stuck in the first iteration. This pr fixes it

@samsja samsja requested review from Jackmin801 and apaz-cli January 7, 2025 14:21
Copy link
Member

@Jackmin801 Jackmin801 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh nice. didnt think of that. I just removed the tail

@samsja
Copy link
Collaborator Author

samsja commented Jan 7, 2025

Oh nice. didnt think of that. I just removed the tail

I did not think about it neither, claude did

@samsja samsja merged commit 001f6c7 into main Jan 7, 2025
1 of 2 checks passed
@samsja samsja deleted the feat-script branch January 7, 2025 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants