Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add soap optimizer #186

Merged
merged 6 commits into from
Jan 10, 2025
Merged

add soap optimizer #186

merged 6 commits into from
Jan 10, 2025

Conversation

samsja
Copy link
Collaborator

@samsja samsja commented Jan 9, 2025

No description provided.

Jackmin801
Jackmin801 approved these changes Jan 9, 2025
View reviewed changes
Copy link
Member

@Jackmin801 Jackmin801 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I didnt realize we didnt merge the [optim.optim] changes though haha. Have a bit of confusion around how state dict works for it but otherwise all good :)

src/zeroband/utils/__init__.py Show resolved Hide resolved
@samsja samsja requested a review from apaz-cli January 10, 2025 07:41
@samsja samsja mentioned this pull request Jan 10, 2025
Closed
@samsja samsja requested a review from Jackmin801 January 10, 2025 08:12
Jackmin801
Jackmin801 approved these changes Jan 10, 2025
View reviewed changes
Copy link
Member

@Jackmin801 Jackmin801 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

coolio. lfgtm

@samsja samsja merged commit d958229 into main Jan 10, 2025
2 checks passed
@samsja samsja deleted the feat-soap branch January 10, 2025 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jackmin801 Jackmin801 Jackmin801 approved these changes

@faresobeid faresobeid Awaiting requested review from faresobeid

@apaz-cli apaz-cli Awaiting requested review from apaz-cli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samsja @Jackmin801