Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add named runs and get_env_config() #194

Merged
merged 2 commits into from
Jan 15, 2025
Merged

Add named runs and get_env_config() #194

merged 2 commits into from
Jan 15, 2025

Conversation

apaz-cli
Copy link
Contributor

Let's slowly unify the way we handle configs and env vars. We can slowly move over to using the new get_env_config().

# Then returns ZERO_BAND_TRAIN_MEMORY_PROFILER_FREQ if set in env.
# Then returns 10 if train or config.train.memory_profiler are None.
# Otherwise, returns the value of config.train.memory_profiler.freq.
get_env_config(config, "train.memory_profiler.freq", 10)

Hopefully being able to use an env var for named runs will prevent losing experiment results in the future. And having all the configs in one place demystifies some things.

Copy link
Collaborator

@samsja samsja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lfgtm !

@apaz-cli apaz-cli merged commit 8bec8a8 into main Jan 15, 2025
2 checks passed
@apaz-cli apaz-cli deleted the ap/named_runs branch January 15, 2025 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants