feature/issue 96 enhanced copy to clipboard with PNPM docs #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thescientist13
added
docs
✅ Deploy Preview for super-tapioca-5987ce ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
thescientist13
force-pushed
the
feature/issue-96-copy-clipboard
branch
from
755280a to
9bed337
Compare
thescientist13
changed the title
thescientist13
force-pushed
the
feature/issue-96-copy-clipboard
branch
from
9bed337 to
1ab52a9
Compare
thescientist13
changed the title
thescientist13
force-pushed
the
feature/issue-96-copy-clipboard
branch
from
442f2c8 to
485c9ed
Compare
thescientist13
changed the title
thescientist13
changed the title
|
Seems like some snippets are getting mangled during prerendering when used with the ctc-block component and / or are otherwise not having their HTML escaped 😞 develop build Currently impacting these examples, which I had to leave as normal markdown code fences
Seems like a minimal reproduction <app-ctc-block variant="snippet" heading="src/pages/users.js">
```js
// eslint-disable-next-line no-unused-vars
export async function getBody(compilation, page, request) {
const users = await fetch("http://www.example.com/api/users").then((resp) => resp.json());
const timestamp = new Date().getTime();
return `
<body>
<h1>Hello from the server rendered users page! 👋</h1>
</body>
`;
}
```
</app-ctc-block>Escaping makes it work, but shows the <app-ctc-block variant="snippet" heading="src/pages/users.js">
```js
// eslint-disable-next-line no-unused-vars
export async function getBody(compilation, page, request) {
const users = await fetch("http://www.example.com/api/users").then((resp) => resp.json());
const timestamp = new Date().getTime();
return \`
<body>
<h1>Hello from the server rendered users page! 👋</h1>
</body>
\`;
}
```
</app-ctc-block>
Also, for some reason on the SSR page, the styles / images are all busted too? 😱 |
thescientist13
added
the
needs upstream
Open
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
resolves #96
Summary of Changes
TODO
public-hoist-pattern[]=@lit-labs/*and wc-compiler for PNPM users$should be white in the output for runners variantUpstreams
Thoughts / Questions
<details>+<summary>, or maybepopoverfor this? Perhaps align with Progressively Enhanced Capabilities content #81 ?