[Feature] Add arithmetic types, plaintext, and conversion of plaintext & records to JS objects #944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamalwaysuncomfortable
requested review from
jaketarnow,
Pauan,
esren0x and
onetrickwolf
iamalwaysuncomfortable
changed the title
Pauan
requested changes
Dec 5, 2024
website/src/workers/worker.js
Outdated
| @@ -418,5 +418,7 @@ self.addEventListener("message", (ev) => { | |||
| programManager.setHost(defaultHost); | |||
| } | |||
| })(); | |||
| } else if (ev.data.type === "PROPOSE_GAME") { | |||
There was a problem hiding this comment.
This is a mistake, I shall remove.
There was a problem hiding this comment.
Feedback addressed, @Pauan - when there's time to double check, let me know.
website/src/workers/worker.js
Outdated
| @@ -418,5 +418,7 @@ self.addEventListener("message", (ev) => { | |||
| programManager.setHost(defaultHost); | |||
| } | |||
| })(); | |||
| } else if (ev.data.type === "PROPOSE_GAME") { | |||
There was a problem hiding this comment.
This is a mistake, I shall remove.
wasm/src/ledger/transaction.rs
Outdated
| let tpk = Group::from(transition.tpk()); | ||
| let tcm = Field::from(transition.tcm()); | ||
| let scm = Field::from(transition.scm()); | ||
| if convert_to_js { |
There was a problem hiding this comment.
This will only work if its first wrapped in JsValue, which seems acceptable.
Pauan
requested changes
Dec 10, 2024
Pauan
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
From several requests and issues surrounding the SDK, the following features have been flagged as important to add.
Addition Field, Scalar, and Group Types
Addition of
Field,Group, andScalartypes and core arithmetic methods on those types allowing useful work to be done using algebraic types.Accessible Plaintext and Record Data + Conversion of Aleo types to JS type.
This PR adds the ability to access:
RecorddirectlyStructfieldsPlaintexttypes into JS objects. This includes AleoLiteral( i.e.address,boolean,i8/i16/i32/i64/i128/u8/u16/u32/u64/u128,field,scalar,signature),Struct, andArraytypes) into JS types.Transition and Transaction Data Accessor Methods
The ability to search for
records, and get theinputsandoutputsofTransitionsandTransactions.Addition of
GraphKeyandComputeKeyThis PR adds both the
GraphKeyandComputeKeyto the sdk, allowing GraphKeys to be used directly to determine ownershiprecords.Test Plan