Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We should avoid panics, this PR adds checking if additions are allowed in snarkVM. I could not find problematic subtraction cases.
For this, we should agree on the attack surface. I can imagine the following attack vectors:
Test Plan
The existing tests should cover it.
Related PRs
Succeeding: https://github.com/AleoHQ/snarkVM/pull/1584
Compared to that PR, here we only care about fixing addition overflow and we are rebased on testnet3