[Perf] Speed up locking in DataMap::atomic_checkpoint #2506
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joske
approved these changes
Jun 26, 2024
raychu86
approved these changes
Jul 3, 2024
|
@ljedrz Does this PR need any refreshing (cargo fmt looks to be failing) since it hasn't been merged in a while |
Signed-off-by: ljedrz <[email protected]>
ljedrz
force-pushed
the
perf/lock_tweaks
branch
from
bce8263 to
9bbba95
Compare
|
I rebased just to be sure everything is in order; I ran |
|
Yea seems like it's due to a CI versioning issue. Can revisit once CI is run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a tiny change I found while pruning my local branches, and I wouldn't want us to miss it.
The guard on
atomic_batchis utilized a lot, which - in the current setup - also causes the guard oncheckpointsused in theatomic_checkpointmethod to be in force significantly longer than necessary.This tiny change with no impact on logic fixes this, as confirmed by guard lifetime measurements in a
--devrun; the maximum guard (oncheckpoints) duration is reduced by ~75%.