Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only keep track of recently used stacks in memory + unified storage #2592

Draft
wants to merge 45 commits into
base: staging
Choose a base branch
from
Draft

Only keep track of recently used stacks in memory + unified storage #2592

wants to merge 45 commits into from

Conversation

vicsn
Copy link
Collaborator

@vicsn vicsn commented Jan 11, 2025 •
edited
Loading

Motivation

Combines #2591 + #2590 to see if we can make CI happy.

Remaining issues:

  • Clippy
  • test_get_block and test_load_unchecked expect different metadata.
  • SIGKILL for ledger-with-rocksdb and synthesizer (also on another PR, even with --test-threads=1).
  • synthesizer-integration because of test_rand.aleo/rand_chacha_check, which internal state changed?

ljedrz and others added 30 commits January 10, 2025 15:03
@ljedrz
refactor: simplify and unify the storage setup for tests
ef9c5ea 
Signed-off-by: ljedrz <[email protected]>
@vicsn
Only keep track of recently used stacks in memory.
44fc174 
This should - as far as we know - eliminate unbounded memory growth.
To avoid memory leaks, we only evict "root" stacks from the cache.
@vicsn
Revert MAX_TRANSMISSIONS_PER_BATCH location
9486378
@vicsn
Fix circleci resource
9e56e07
@vicsn
Lower MAX_STACKS when testing
4a93690
@vicsn
Only keep track of recently used stacks in memory.
515c844 
This should - as far as we know - eliminate unbounded memory growth.
To avoid memory leaks, we only evict "root" stacks from the cache.
@vicsn
Revert MAX_TRANSMISSIONS_PER_BATCH location
bf227f9
@vicsn
Fix circleci resource
3331957
@vicsn
Lower MAX_STACKS when testing
0d6a49b
@ljedrz @vicsn
fix: align the Process store with the VM one
f011849 
Signed-off-by: ljedrz <[email protected]>
@vicsn
Resolve bugs
a4ee5df
@vicsn
Fix tests: don't superfluously cache credits.aleo
dc4e68e
@vicsn
Update Cargo.lock
506326d
@vicsn
Update circleci config
72470ac
@vicsn
Update MAX_STACKS to fix test_long_import_chain
ed0f01c
@vicsn
Resolve bugs
135e279
@vicsn
Fix tests: don't superfluously cache credits.aleo
e76606d
@vicsn
Update circleci config
678fa94
@vicsn
Update MAX_STACKS to fix test_long_import_chain
ce57e74
@vicsn
Moar CI resources
0455b0b
@vicsn @ljedrz
Update ledger/narwhal/batch-header/src/lib.rs
9e19924 
Co-authored-by: ljedrz <[email protected]>
Signed-off-by: vicsn <[email protected]>
@vicsn @ljedrz
Update synthesizer/process/src/lib.rs
8bf0d8d 
Co-authored-by: ljedrz <[email protected]>
Signed-off-by: vicsn <[email protected]>
@vicsn @ljedrz
Update synthesizer/process/src/lib.rs
b884134 
Co-authored-by: ljedrz <[email protected]>
Signed-off-by: vicsn <[email protected]>
@vicsn @ljedrz
Update synthesizer/process/src/lib.rs
ed2d269 
Co-authored-by: ljedrz <[email protected]>
Signed-off-by: vicsn <[email protected]>
@vicsn @ljedrz
Update synthesizer/process/src/lib.rs
f9eaab6 
Co-authored-by: ljedrz <[email protected]>
Signed-off-by: vicsn <[email protected]>
@vicsn
Get rid of stacks contention
fc0ec5f
@vicsn
Correct typedef name
3291ccc
@vicsn
Fix slow test; might need DB fix to pass
12345aa
@vicsn
Reduce size of feature gating diff
b1e2a0a
@vicsn
Only use num_stacks_in_memory in tests
f1022e3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vicsn @ljedrz