Python 3.13 support #2306
Python 3.13 support #2306
Conversation
|
Since 3.8 is EOL, shouldn't we drop support for that too? |
|
I think that Python 3.8 doesn't conflict with adding Python 3.13 support and dropping it is outside of this PR's scope |
|
Fair point :) |
isort/stdlibs/py312.py
Outdated
| @@ -14,7 +14,9 @@ | |||
| "argparse", | |||
| "array", | |||
| "ast", | |||
| "asynchat", | |||
There was a problem hiding this comment.
Please remove these.
They were all removed in 3.12:
https://docs.python.org/3/whatsnew/3.12.html#asynchat-and-asyncore
There was a problem hiding this comment.
I can remove it, but it was added by the scripts. So it will automatically appear on the next run because it's still present in the corresponding documentation: https://docs.python.org/3.12/library/asynchat.html#module-asynchat
Mb it would be better to use stdlibs package or adopt it's approach to modules generation?
There was a problem hiding this comment.
Aha, the problem was caused by the docs re-adding module pages which had bee removed, but as stubs:
Mb it would be better to use stdlibs package or adopt it's approach to modules generation?
Yeah, sounds like a good idea to use stdlibs 👍
There was a problem hiding this comment.
updated the script to use stdlibs and ran it
isort/stdlibs/py313.py
Outdated
| "argparse", | ||
| "array", | ||
| "ast", | ||
| "asynchat", |
There was a problem hiding this comment.
Similarly, this list contains lots of modules that have been removed in 3.12 or earlier.
Was this list created using the mkstdlibs.py script?
There was a problem hiding this comment.
all changes to stdlibbs/py*.py were generated by mkstdlibs.py scripts
use `stdlibs` for stdlibs packages list
|
Awesome! Could you rebase this so we can get this merged? |
|
I had to drop python3.8 support to make builds pass on python3.13 because some packages required a version, which do not support python3.8 (not sure how it passed before the At the same time, the prod package could have been installed with both 3.8 and 3.13, so I'm open to rolling back this commit if 3.8 support is considered more important than builds with python3.13 in PRs |
|
I think it's fine to drop 3.8, as mentioned before, it's already EOL: We could merge this as-is and do a more thorough 3.8 cleanup in another PR. |
|
@mayty This can be rebased on |
Issue/2305 pull upstream
|
See PyCQA/meta#64 (comment) I have stopped merging anything. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2306 +/- ##
=======================================
Coverage 99.12% 99.12%
=======================================
Files 39 40 +1
Lines 3095 3096 +1
Branches 787 787
=======================================
+ Hits 3068 3069 +1
Misses 15 15
Partials 12 12 |
There was a problem hiding this comment.
@mayty thanks a lot for your contribution. Your changes look good to me. I kindly ask to rebase again and generate a new poetry.lock. The integration tests were failing and I just merged #2329.
Also, since you are supporting a higher version on Python, I also suggest to increase the integration tests version up to 3.12 on .github/workflows/integration.yml.
There was a problem hiding this comment.
@staticdev Pushed the changes you requested to help move this along :)
There are two more remaining questions from my side. Other than that I think also think this looks good.
pyproject.toml
Outdated
| @@ -80,6 +81,7 @@ types-setuptools = ">=70.0.0.20240523" | |||
| types-colorama = ">=0.4.2" | |||
| types-toml = ">=0.1.3" | |||
| vulture = ">=1.0" | |||
| stdlibs = ">=2024.10.21.16" | |||
There was a problem hiding this comment.
It seems as if [tool.poetry.dev-dependencies] is almost in alphabetical order. Not sure if we want to add a commit to do so.
There was a problem hiding this comment.
I'm all for alphabetical order, but only if there is gonna be a commitment to maintaining it in the future (at least a mention in the coding-standart doc)
There was a problem hiding this comment.
+1 for alhabetical order.. I normally have in all project I maintain.
There was a problem hiding this comment.
Sorted dev dependencies
|
Thanks @mayty @DanielNoord @hugovk |
Related issue: 2305