-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert images to AVIF during API docs generation #2556
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Could you please document in the README prerequisites section that you need to install imagemagick and link to its install guide?
Co-authored-by: Eric Arellano <[email protected]>
Soft push back on this: Most users will have it installed already, and if they don't they'll immediately see the message explaining that they need it. It's also likely to become outdated if we ever change how the pipeline works. |
Co-authored-by: Eric Arellano <[email protected]>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My README suggestion isn't blocking. Thanks for adding the install to the console log!
My mistake; I didn't need to install it so I assumed it came pre-installed with OSX, it must have been a dependency of something else. |
Includes a feature flag as requested. This requires the user have ImageMagick installed.