Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert TaylorCluster Optimizations of #199 #220

Merged
merged 7 commits into from
Jan 17, 2025
Merged

Revert TaylorCluster Optimizations of #199 #220

merged 7 commits into from
Jan 17, 2025

Conversation

VictorVanthilt
Copy link
Contributor

No description provided.

@VictorVanthilt VictorVanthilt requested a review from lkdvos January 3, 2025 08:24
@codecov Codecov
Copy link

codecov bot commented Jan 3, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
src/MPSKit.jl 100.00% <ø> (ø)
src/algorithms/timestep/timeevmpo.jl 83.97% <100.00%> (-0.83%) ⬇️

... and 2 files with indirect coverage changes

@VictorVanthilt VictorVanthilt changed the title Revert TaylorCluster Optimizations of #199 Revert TaylorCluster Optimizations of QuantumKitHub/MPSKit.jl/#199 Jan 3, 2025
@VictorVanthilt VictorVanthilt changed the title Revert TaylorCluster Optimizations of QuantumKitHub/MPSKit.jl/#199 Revert TaylorCluster Optimizations of #199 Jan 3, 2025
@VictorVanthilt VictorVanthilt changed the title Revert TaylorCluster Optimizations of #199 Revert TaylorCluster Optimizations of !199 Jan 3, 2025
@VictorVanthilt VictorVanthilt changed the title Revert TaylorCluster Optimizations of !199 Revert TaylorCluster Optimizations of #199 Jan 3, 2025
lkdvos
lkdvos requested changes Jan 3, 2025
View reviewed changes
Copy link
Member

@lkdvos lkdvos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I would say good to go if we add some tests?

@VictorVanthilt VictorVanthilt marked this pull request as draft January 7, 2025 06:44
@VictorVanthilt VictorVanthilt marked this pull request as ready for review January 17, 2025 18:31
@VictorVanthilt VictorVanthilt requested a review from lkdvos January 17, 2025 18:31
@lkdvos lkdvos merged commit e42e898 into QuantumKitHub:master Jan 17, 2025
27 of 28 checks passed
@VictorVanthilt
Copy link
Contributor Author

Any idea why the julia 1 test on macos is giving LAPACK errors?

@VictorVanthilt VictorVanthilt deleted the TaylorCluster-undo branch January 17, 2025 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lkdvos lkdvos lkdvos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VictorVanthilt @lkdvos