Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various (hopefully final) fixes (again) #233

Merged
merged 13 commits into from
Jan 22, 2025
Merged

Various (hopefully final) fixes (again) #233

merged 13 commits into from
Jan 22, 2025

Conversation

lkdvos
Copy link
Member

@lkdvos lkdvos commented Jan 22, 2025

Fixes the periodic_boundary_conditions functions, and small other bugs that came to light while rerunning the examples and the README

@lkdvos lkdvos linked an issue Jan 22, 2025 that may be closed by this pull request
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 2.11268% with 139 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/algorithms/toolbox.jl 0.00% 93 Missing ⚠️
src/operators/abstractmpo.jl 0.00% 29 Missing ⚠️
src/operators/mpo.jl 0.00% 7 Missing ⚠️
src/operators/mpohamiltonian.jl 0.00% 7 Missing ⚠️
src/algorithms/changebonds/optimalexpand.jl 25.00% 3 Missing ⚠️
Files with missing lines Coverage Δ
src/algorithms/groundstate/idmrg.jl 68.10% <ø> (-30.21%) ⬇️
src/environments/abstract_envs.jl 70.27% <100.00%> (-21.63%) ⬇️
src/algorithms/changebonds/optimalexpand.jl 34.54% <25.00%> (-65.46%) ⬇️
src/operators/mpo.jl 4.94% <0.00%> (-89.18%) ⬇️
src/operators/mpohamiltonian.jl 49.29% <0.00%> (-41.46%) ⬇️
src/operators/abstractmpo.jl 4.45% <0.00%> (-34.61%) ⬇️
src/algorithms/toolbox.jl 14.49% <0.00%> (-78.85%) ⬇️

... and 56 files with indirect coverage changes

@lkdvos lkdvos merged commit c419625 into master Jan 22, 2025
7 of 27 checks passed
@lkdvos lkdvos deleted the readme-fix branch January 22, 2025 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] periodic_boundary_conditions gives invalid results
2 participants