LazySum: Functionality to perform TDVP and find_groundstate with a lazy sum #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Holy traits to follow.
|
With the addition of time dependent operators in mind for the future, some support to differentiate between time dependent and time-independent operators with Holy traits, is already added. I'm not sure my implementation is satisfactory and if this system should be extended to derivative operators or left as is. |
lkdvos
requested changes
Nov 30, 2023
Co-authored-by: DaanMaertens <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #91 +/- ##
==========================================
- Coverage 84.72% 83.79% -0.93%
==========================================
Files 61 63 +2
Lines 3784 3827 +43
==========================================
+ Hits 3206 3207 +1
- Misses 578 620 +42 ☔ View full report in Codecov by Sentry. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
src/algorithms/toolbox.jl
Outdated
Comment on lines
194
to
195
| envs isa MultipleEnvironments && | ||
| throw(ArgumentError("The environment cannot be Lazy i.e. use environments of sum(H)")) |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| envs isa MultipleEnvironments && | |
| throw(ArgumentError("The environment cannot be Lazy i.e. use environments of sum(H)")) | |
| envs isa MultipleEnvironments && throw( | |
| ArgumentError("The environment cannot be Lazy i.e. use environments of sum(H)") | |
| ) |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new struct
LazySumfor a lazy sum of operators, together with aMultipleEnvironmentscache for the corresponding environments. This lazy sum only gets evaluated when it is needed e.g. in expectation_valueor when the action of derivative operator is calculated. Thanks to support for the latter
LazySumworks out of the box for VUMPS, GradientGrassmann or TDVP algorithms. For iDMRG some minor changes were needed in order to make it work with the iDMRG environments.