Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MIVisionX ASAN - Exclude library_tests from ASAN pkg #1224

Merged
merged 4 commits into from
Nov 9, 2023

Conversation

arvindcheru
Copy link
Contributor

@arvindcheru arvindcheru commented Nov 4, 2023

Changes Proposed:

  • Exclude test files from MIVisionX ASAN package.
  • Fix for SWDEV-430827

@pramenku
Copy link

pramenku commented Nov 6, 2023

@arvindcheru
I guess, we need to keep it 1st in "develop" branch then from there it needs to moved to "master"

Also, I have one query.
I see, we are disabling binary file for ASAN?
When we have test package enabled, we need those binary files, correct?

Feature ticket for asan instrument test package , where this binary is needed, https://ontrack-internal.amd.com/browse/SWDEV-429801

@arvindcheru arvindcheru closed this Nov 6, 2023
@arvindcheru arvindcheru reopened this Nov 6, 2023
@kiritigowda kiritigowda self-assigned this Nov 6, 2023
@kiritigowda kiritigowda added enhancement New feature or request bugfix Bug fixes to existing features labels Nov 6, 2023
@kiritigowda
Copy link
Collaborator

kiritigowda commented Nov 7, 2023

@arvindcheru - some observation in the change. The only libraries and executables which MIVisionX HIP installs is listed below. The apps and utilities are not built with TOT CMakeLists. Changes for ASAN will never propagate to those CMake.

Libraries

ibopenvx.so
libvxu.so
libvx_opencv.so
libvx_amd_media.so
libvx_amd_custom.so
libvx_nn.so
libvx_amd_migraphx.so
libvx_rpp.so
librocal.so

Executables

runvx
mv_compile

@arvindcheru arvindcheru changed the title MIVisionX ASAN - Exclude additional files from ASAN packaging MIVisionX ASAN - Exclude library_tests from ASAN pkg Nov 8, 2023
@arvindcheru
Copy link
Contributor Author

Changes Proposed:

  • Exclude bin and test files from MIVisionX ASAN package.

@arvindcheru - some observation in the change. The only libraries and executables which MIVisionX HIP installs is listed below. The apps and utilities are not built with TOT CMakeLists. Changes for ASAN will never propagate to those CMake.

Libraries

ibopenvx.so
libvxu.so
libvx_opencv.so
libvx_amd_media.so
libvx_amd_custom.so
libvx_nn.so
libvx_amd_migraphx.so
libvx_rpp.so
librocal.so

Executables

runvx
mv_compile

Updated the change as discussed considering the above review comments

@kiritigowda kiritigowda changed the base branch from master to develop November 9, 2023 13:22
@kiritigowda kiritigowda merged commit 3baf23d into ROCm:develop Nov 9, 2023
4 checks passed
kiritigowda pushed a commit that referenced this pull request Nov 9, 2023
* MIVisionX ASAN - Exclude additional files from ASAN packaging

* Review Comments Updated

* Revert "MIVisionX ASAN - Exclude additional files from ASAN packaging"

This reverts commit c744b6d.

* MIVisionX ASAN - Exclude library_tests from ASAN pkg
@arvindcheru arvindcheru deleted the master-asan-pkg-patch-1 branch December 8, 2023 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Bug fixes to existing features enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants