Add a source formatting CI #125
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Galiffi <[email protected]>
Signed-off-by: David Galiffi <[email protected]>
Mustaballer
pushed a commit
that referenced
this pull request
Jul 12, 2024
Mustaballer
added a commit
that referenced
this pull request
Jul 17, 2024
* copy changes from #125 * try running sh script check_format.sh & check_copyright.sh in linting.yml * add test file and add more logging to check_format.sh for testing * test ci with unformatted example.cpp file * run precommit hook on all files * try specific version of clang-format * modify check_format.sh to use clang-format * remove example.cpp and additional logging * use clang-format-18 * Add missing sudo command to dependencies installation in linting.yml * use clang-format 18 for precommit-hooks * revert changes to check_format.sh * use check_format.sh in ci * add GIT_CLANG_FORMAT as env variable for script * fetch all branches in linting.yml * fix lint error * add all_files flag to check_format.sh so runs on all files * Simplify argument parsing for `--all-files` and source commit. --------- Co-authored-by: Mustaballer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.