Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass in $ROCM_EXAMPLES_ROOT and $TEST_PACKAGE_INSTALL_PREFIX in install_packages.sh #158

Merged
merged 4 commits into from
Sep 3, 2024

Conversation

Mustaballer
Copy link
Contributor

@Mustaballer Mustaballer commented Sep 3, 2024

The build_packages.sh script previously assumed that the source is located in BUILD_DIR/.., instead I pass in $ROCM_EXAMPLES_ROOT to locate the source and $TEST_PACKAGE_INSTALL_PREFIX for custom installation for the test packages.

@Mustaballer
Copy link
Contributor Author

Mustaballer commented Sep 3, 2024

@dgaliffiAMD I attached the file contents for the test deb and rpm package below:
test-rpm-file-contents.txt
test-deb-file-contents.txt

@Mustaballer Mustaballer marked this pull request as ready for review September 3, 2024 19:41
Copy link
Collaborator

@dgaliffiAMD dgaliffiAMD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Mustaballer, this looks good.

@Mustaballer Mustaballer merged commit f66d618 into develop Sep 3, 2024
4 checks passed
@dgaliffiAMD dgaliffiAMD deleted the add-tutorial-directory branch September 3, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants