Add support for layouts #587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micmelesse
reviewed
May 16, 2024
| @@ -1102,7 +1082,9 @@ def varlen_input_helper(Z, HQ, HK, N_CTX_Q, N_CTX_K, D_HEAD, dtype): | |||
| @pytest.mark.parametrize('use_alibi', [True, False]) | |||
| def test_op_fwd(Z, HQ, HK, N_CTX_Q, N_CTX_K, D_HEAD, causal, use_alibi, dtype=torch.float16): | |||
| torch.manual_seed(20) | |||
| q, k, v, input_metadata = input_helper(Z, HQ, HK, N_CTX_Q, N_CTX_K, D_HEAD, dtype) | |||
| # TODO: Adapt test for bshd | |||
| layout = 'bhsd' | |||
There was a problem hiding this comment.
Do we need to add the layouts quickly for some reason? It would be nice if we could test at least one other layout. If we need to move quick, I am fine adding the tests later.
There was a problem hiding this comment.
No, not necessary to get it in quickly. I guess I was just being lazy. Good to have tests - Done.
micmelesse
pushed a commit
that referenced
this pull request
Jun 14, 2024
Add support for layouts commonly used by users. Add option for varlen / thd layout to specify equal context lengths for all batches. Also often used by users.
micmelesse
pushed a commit
that referenced
this pull request
Jun 19, 2024
Add support for layouts commonly used by users. Add option for varlen / thd layout to specify equal context lengths for all batches. Also often used by users.
micmelesse
pushed a commit
that referenced
this pull request
Jul 16, 2024
Add support for layouts commonly used by users. Add option for varlen / thd layout to specify equal context lengths for all batches. Also often used by users.
micmelesse
pushed a commit
that referenced
this pull request
Jul 16, 2024
Add support for layouts commonly used by users. Add option for varlen / thd layout to specify equal context lengths for all batches. Also often used by users.
micmelesse
pushed a commit
that referenced
this pull request
Oct 28, 2024
Add support for layouts commonly used by users. Add option for varlen / thd layout to specify equal context lengths for all batches. Also often used by users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for layouts commonly used by users.
Add option for varlen / thd layout to specify equal context lengths for all batches. Also often used by users.