Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce tools for consistency checking #111

Merged
merged 10 commits into from
Nov 13, 2024
Merged

Introduce tools for consistency checking #111

merged 10 commits into from
Nov 13, 2024

Conversation

WardLT
Copy link
Contributor

@WardLT WardLT commented Nov 13, 2024

Be able to check if, for example, the sign convention is wrong.

Fixes #57

@coveralls
Copy link

coveralls commented Nov 13, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11823625885

Details

  • 60 of 62 (96.77%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 95.634%
Changes Missing Coverage Covered Lines Changed/Added Lines %
battdat/consistency/base.py 4 5 80.0%
battdat/consistency/current.py 32 33 96.97%
Totals Coverage Status
Change from base Build 11803498955: 0.3%
Covered Lines: 1161
Relevant Lines: 1214
💛 - Coveralls

@WardLT WardLT marked this pull request as ready for review November 13, 2024 18:01
@WardLT WardLT merged commit b07aaff into main Nov 13, 2024
4 checks passed
@WardLT WardLT mentioned this pull request Nov 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide way to check sign of current is correct
2 participants
@WardLT @coveralls