Skip to content

Commit

Permalink
fix ird download link
Browse files Browse the repository at this point in the history
IRDs that have spaces and other characters like () didnt create a proper link
  • Loading branch information
FlexBy420 authored Dec 14, 2024
1 parent 09aedeb commit 1c77963
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Clients/IrdLibraryClient/IrdClient.cs
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,6 @@ public async Task<List<Ird>> DownloadAsync(string productCode, string localCache
}
}

public static Uri GetDownloadLink(string relativeLink) => new(BaseDownloadUri, relativeLink);
public static string GetDownloadLink(string relativeLink) => Uri.EscapeUriString(new Uri(BaseDownloadUri, relativeLink).ToString());

Check warning on line 128 in Clients/IrdLibraryClient/IrdClient.cs

View workflow job for this annotation

GitHub Actions / Build Release

'Uri.EscapeUriString(string)' is obsolete: 'Uri.EscapeUriString can corrupt the Uri string in some cases. Consider using Uri.EscapeDataString for query string components instead.' (https://aka.ms/dotnet-warnings/SYSLIB0013)

Check warning on line 128 in Clients/IrdLibraryClient/IrdClient.cs

View workflow job for this annotation

GitHub Actions / Build Release

'Uri.EscapeUriString(string)' is obsolete: 'Uri.EscapeUriString can corrupt the Uri string in some cases. Consider using Uri.EscapeDataString for query string components instead.' (https://aka.ms/dotnet-warnings/SYSLIB0013)

Check warning on line 128 in Clients/IrdLibraryClient/IrdClient.cs

View workflow job for this annotation

GitHub Actions / Run Tests

'Uri.EscapeUriString(string)' is obsolete: 'Uri.EscapeUriString can corrupt the Uri string in some cases. Consider using Uri.EscapeDataString for query string components instead.' (https://aka.ms/dotnet-warnings/SYSLIB0013)

Check warning on line 128 in Clients/IrdLibraryClient/IrdClient.cs

View workflow job for this annotation

GitHub Actions / Run Tests

'Uri.EscapeUriString(string)' is obsolete: 'Uri.EscapeUriString can corrupt the Uri string in some cases. Consider using Uri.EscapeDataString for query string components instead.' (https://aka.ms/dotnet-warnings/SYSLIB0013)
}
}

0 comments on commit 1c77963

Please sign in to comment.