Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stickers converter #10021

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Soheab
Copy link
Contributor

@Soheab Soheab commented Nov 20, 2024

Summary

This PR makes it possible to ask users to input a sticker by annotating an ext.commands.Command's parameter to any of the sticker types. This works similarly to the Attachment converter.

At the time of writing this description, I noticed that there is already a converter for guild stickers, but.. it only searches in cache for the name or id meanwhile this can get any uploaded stickers. But.. this implementation does conflict with the converter and I'm unsure what to do about that now.. (fml)

Another thing

It would be neat if you could specify a union of sticker types but I couldn't figure out a way to implement that cleanly since Attachment doesn't support that either.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@Rapptz
Copy link
Owner

Rapptz commented Jan 15, 2025

I personally don't really see much point in this feature? The attachment converter has merits since it's a relatively common thing to desire but stickers feel niche considering the work being done here?

@Soheab
Copy link
Contributor Author

Soheab commented Jan 16, 2025

I personally don't really see much point in this feature? The attachment converter has merits since it's a relatively common thing to desire but stickers feel niche considering the work being done here?

I personally don't see the point either. I did it just because it's possible, but I do think the code is messy.

From searching for "sticker converter" on the server, three results appeared, one of which is a help post ( https://discord.com/channels/336642139381301249/1265080971770990693 ) that includes a workaround using a callable default.

It's safe to say there is not much merit to this, so I'll leave it up to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants