forked from jonan/ForkHub
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Implement a workable solution for issue jonan#345
Also tackle legacy device support, downgrade minSdkVersion to 18 from 19 unless someone can tell me that there is a reason the code base must be on API 19. Note: I've been working at this to be able to continue to maintain at least one Github client working with BB10 (Blackberry OS10), which has ForkHub as its sole Github client in the app store BlackberryWorld (also in Amazon store), however this app stopped working about a year or so back, and this should provide a fix. Work with upstream maintainers to sort out cleanest fix as this only takes into account a build specific to the legacy devices.
- Loading branch information
1 parent
cfcd0ab
commit 6744ab1
Showing
2 changed files
with
38 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6744ab1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few things to note on this commit:
6744ab1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another part of the "problem" is that the existing original code is using some deprecated methods. Need to get off of those, not because the signatures are going away soon, but this seems to have some impact on the behavior in having problems with reflection and how the SSLContext gets loaded. https://square.github.io/okhttp/3.x/okhttp/okhttp3/OkHttpClient.Builder.html
6744ab1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My BB10 device still fails but my Nexus works with the above code. BB10 needs to go onto the debugger. I have to figure out how to set that up.
6744ab1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So a few more details on the BB10 android 4.3 issue:
To setup a dev environment:
A lot of steps ...
Here is the failure on the device: