Skip to content
This repository has been archived by the owner on Oct 1, 2018. It is now read-only.

feat(i18n): Setup ngx-translate in rxjs-docs #267

Merged
merged 1 commit into from
Feb 14, 2018
Merged

feat(i18n): Setup ngx-translate in rxjs-docs #267

merged 1 commit into from
Feb 14, 2018

Conversation

IraErshova
Copy link
Contributor

Setup ngx-translate with English and Russian languages
Add language service
Create language menu
Add unit tests

Setup ngx-translate with english and russian languages
Add language service
Create language menu
Add unit tests
@codecov-io
Copy link

Codecov Report

Merging #267 into master will increase coverage by 2.76%.
The diff coverage is 90.69%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #267      +/-   ##
=========================================
+ Coverage   77.14%   79.9%   +2.76%     
=========================================
  Files          15      17       +2     
  Lines         175     214      +39     
  Branches        7       9       +2     
=========================================
+ Hits          135     171      +36     
- Misses         40      41       +1     
- Partials        0       2       +2
Impacted Files Coverage Δ
src/app/core/data/language.data.ts 100% <100%> (ø)
...c/app/core/components/toolbar/toolbar.component.ts 92.85% <100%> (+7.14%) ⬆️
src/app/app.component.ts 62.06% <83.33%> (+4.37%) ⬆️
src/app/core/services/language.service.ts 89.28% <89.28%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 621c41d...584e008. Read the comment docs.

@niklas-wortmann
Copy link
Member

Looks pretty good. Thanks for the PR. Just a short question, how is this pr related to #144?

@IraErshova
Copy link
Contributor Author

@jwo719 It's a replacement for #144

@niklas-wortmann
Copy link
Member

Ok get it. Thank you

@ashwin-sureshkumar ashwin-sureshkumar merged commit f0ec397 into ReactiveX:master Feb 14, 2018
@ladyleet
Copy link
Member

🤗 y'all! this is amazing!

@SangKa
Copy link

SangKa commented Apr 10, 2018

I'll follow up with the Chinest translation.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants