Fixed certbot-auto deprecation #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chryzsh
changed the title
|
Hi there, thanks for submitting this. We did get the DNS section updated, so it looks like that isn't needed in your pull request anymore. Do you want to remove that so we can test out the bash updates you provided and then merge this in? |
|
I'd have to make a branch out of the first change, and I'm feeling lazy. If you don't mind you can just copy out the the first change to your own dev branch and test it out. At least I don't mind. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've grown to like C2concealer and use it for engagements all the time, so first of all thank you for that!
As per certbot/certbot#8535 they've deprecated certbot-auto, which breaks the bash script. This has been noticed and some fixes can be seen in projects such as https://github.com/killswitch-GUI/CobaltStrike-ToolKit/pull/8/files. I've kind of stolen that code to fix it here as well. I tested it on a fresh Ubuntu 20.04 box and it appears to work fine now.