Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(interactive-chart): hide tradingview default attribution logo #1253

Open
wants to merge 7 commits into
base: v7
Choose a base branch
from
Open

fix(interactive-chart): hide tradingview default attribution logo #1253

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
fe3c24b
fix(interactive-chart): hide tradingview default attribution logo
dtanp-rft Jan 3, 2025
c1bb822
Merge branch 'v7' into fix/tradingview-logo
dtanp-rft Jan 3, 2025
ee5f4a0
fix(interactive-chart): hide tradingview default attribution logo
dtanp-rft Jan 3, 2025
f4e1129
Merge branch 'fix/tradingview-logo' of https://github.com/Refinitiv/r…
dtanp-rft Jan 3, 2025
da9ff6f
Update packages/elements/src/interactive-chart/index.ts
dtanp-rft Jan 3, 2025
02e6302
fix(interactive-chart): hide tradingview default attribution logo
dtanp-rft Jan 3, 2025
ea7d0ff
fix(interactive-chart): hide tradingview default attribution logo
dtanp-rft Jan 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/elements/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -466,7 +466,7 @@
"d3-interpolate": "^3.0.1",
"date-fns": "^2.29.3",
"escape-string-regexp": "^5.0.0",
"lightweight-charts": "^4.1.0",
"lightweight-charts": "^4.2.0",
"tslib": "^2.3.1"
},
"devDependencies": {
Expand Down
9 changes: 5 additions & 4 deletions ...ages/elements/src/interactive-chart/__test__/__snapshots__/interactive-chart.test.snap.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,13 @@ snapshots["interactive-chart/InteractiveChart Default DOM structure is correct"]
<div part="jump-button">
</div>
</div>
<div
<a
href="https://www.tradingview.com"
part="branding-container"
title=""
tooltip="Powered by Trading View"
target="_blank"
title="Charting by Trading View"
>
</div>
</a>
<div part="chart">
</div>
`;
Expand Down
12 changes: 9 additions & 3 deletions packages/elements/src/interactive-chart/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -588,7 +588,8 @@ export class InteractiveChart extends ResponsiveElement {
color: this.theme.backgroundColor
},
textColor: this.theme.textColor,
fontFamily: defaultFontFamily
fontFamily: defaultFontFamily,
attributionLogo: false
},
leftPriceScale: {
borderColor: this.theme.scalePriceBorderColor
Expand Down Expand Up @@ -1183,15 +1184,20 @@ export class InteractiveChart extends ResponsiveElement {
<div part="jump-button-container">
<div part="jump-button"></div>
</div>
<div part="branding-container" title="" tooltip="Powered by Trading View">
<a
href="https://www.tradingview.com"
part="branding-container"
title="Charting by Trading View"
target="_blank"
>
<svg width="33" height="19" viewBox="0 0 611 314" part="branding">
<path
fill-rule="evenodd"
clip-rule="evenodd"
d="M341 124C375.242 124 403 96.2417 403 62C403 27.7583 375.242 0 341 0C306.758 0 279 27.7583 279 62C279 96.2417 306.758 124 341 124ZM481 314H337L467 4H611L481 314ZM124 4H248V128V314H124V128H0V4H124Z"
/>
</svg>
</div>
</a>
<div part="chart"></div>
`;
}
Expand Down
2 changes: 1 addition & 1 deletion packages/theme-compiler/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
"fs-extra": "^8.1.0",
"glob": "^10.3.9",
"htmlparser2": "^4.0.0",
"less": "^4.2.0",
"less": "^4.2.1",
"less-plugin-npm-import": "^2.1.0",
"postcss": "^8.4.30",
"svgo": "^3.2.0",
Expand Down
Loading