-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Soften Profile inheritence rules #262
Conversation
Also deleted isInheritedFrom and isTransitiveProfileOf (unused)
- Add isProfileOf to RO-Crate spec version and profiles to inherit - Entities in the profile need not be redefined in conforming crates
Didn't we decide to remove all this from 1.2? @stain |
This needs to be moved to a different document, right? |
Remove inheritance, at best "referenced/suggested" profiles. |
Decision 2024-04-11: Not do formal inheritance system at RO-Crate level yet before we have tried out how it works with actual implementations (e.g. SHACL, Crate-O modes) -- then facilitate them. |
I have finally managed to tidy up the profile section. Changes:
|
Suggestion in call 2024-04-25 @CaroleGoble was to also look at Delegation pattern:
In a sense we use delegation pattern in https://trefx.uk/5s-crate/0.4/#referencing-a-workflow-crate as instead of subclassing Workflow RO-Crate, it references the Workflow RO-Crate by URL -- one crate to another. I've documented this pattern in #296. This would make the resulting 5s-crate as Workflow Run Crate not conform to any strict inheritance rules, as it would not have the usual Note a side issue: at the moment that 5s-crate is in that case purposefully ignoring the MUST of conformsTo requirements -- we can argue over that separately! |
…ate into profile-inheritance
.. according to Profile Crate definitions
@simleo Good to go..? |
AFAICT, yes |
In some cases, such as Workflow Run Crate there are multiple profiles that are related with inheritance.
There are also less strict inheritance profiles such as https://trefx.uk/trusted-wfrun-crate/0.3/
This section now makes it softer how to list multiple profiles, they are suggestions rather than enforcing any hierarchy.