fix(achievement): show badge on tooltips even when is false (#2359)

RetroAchievements · Apr 18, 2024 · a0558f2 · a0558f2
1 parent 04c0ef6
commit a0558f2
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/app/Helpers/render/achievement.php b/app/Helpers/render/achievement.php
@@ -46,15 +46,17 @@ function achievementAvatar(
         $tooltip = $tooltip !== false ? $achievement : false;
     }
 
+    $iconUrl = $icon !== false && ($icon || !$label) ? $icon : null;
+
     return avatar(
         resource: 'achievement',
         id: $id,
         label: $label !== false && ($label || !$icon) ? $label : null,
         link: route('achievement.show', $id),
         tooltip: is_array($tooltip)
-            ? renderAchievementCard($tooltip, iconUrl: $icon)
+            ? renderAchievementCard($tooltip, iconUrl: $iconUrl)
             : $tooltip,
-        iconUrl: $icon !== false && ($icon || !$label) ? $icon : null,
+        iconUrl: $iconUrl,
         iconSize: $iconSize,
         iconClass: $iconClass,
         context: $context,