-
-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(game): grant Jr Devs access to Developer Interest page #1896
fix(game): grant Jr Devs access to Developer Interest page #1896
Conversation
I don't see why a Jr. Dev with a claim shouldn't be allowed to see other people who might be interested in dev'ing the game. The link is made available to Dev claimants per the following:
Are there concerns that a Jr. Dev would harass other developers interested in the title? It would probably work to just remove the Developer check you've highlighted, and let the check on line 33 deal with it: RAWeb/app/Platform/Controllers/GameDevInterestController.php Lines 33 to 35 in a3be5f7
|
No concern on my end - I assumed Jr Devs being able to even see the link was a bug given they couldn't access the page the link took them to. I've reverted the gameInfo.php change and removed the conditional I highlighted in the OP. |
No concern about Jr Devs seeing additional interest from the CR team. Per a recent vote, we are not permitting Jr Devs to collab until after the mentor program is stood up due to significant issues with recent collabs, but there's no reason they shouldn't be able to see developer interest. |
This PR adjusts the visibility of the "View Developer Interest" link on the game page devbox such that it is never visible to Junior Developers.
Currently, the URL is guarded from Jr Devs, so it's causing some confusion that the link itself is appearing for them:
RAWeb/app/Platform/Controllers/GameDevInterestController.php
Lines 23 to 25 in a3be5f7