Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(game): grant Jr Devs access to Developer Interest page #1896

Merged

Conversation

wescopeland
Copy link
Member

This PR adjusts the visibility of the "View Developer Interest" link on the game page devbox such that it is never visible to Junior Developers.

Currently, the URL is guarded from Jr Devs, so it's causing some confusion that the link itself is appearing for them:

if ($permissions < Permissions::Developer) {
abort(403);
}

@wescopeland wescopeland requested a review from a team September 30, 2023 03:03
@wescopeland wescopeland changed the title fix(game): only show Developer Interest link to full devs fix(game): only show Developer Interest link to full devs and above Sep 30, 2023
@Jamiras
Copy link
Member

Jamiras commented Sep 30, 2023

I don't see why a Jr. Dev with a claim shouldn't be allowed to see other people who might be interested in dev'ing the game. The link is made available to Dev claimants per the following:

This gives the claimant insight into other devs that they could bounce ideas off of, or inquire about collaborating.

Are there concerns that a Jr. Dev would harass other developers interested in the title?

It would probably work to just remove the Developer check you've highlighted, and let the check on line 33 deal with it:

if ($permissions < Permissions::Moderator && !hasSetClaimed($request->user()->User, $gameId, true)) {
abort(403);
}

@wescopeland
Copy link
Member Author

No concern on my end - I assumed Jr Devs being able to even see the link was a bug given they couldn't access the page the link took them to.

I've reverted the gameInfo.php change and removed the conditional I highlighted in the OP.

@wescopeland wescopeland changed the title fix(game): only show Developer Interest link to full devs and above fix(game): grant Jr Devs access to Developer Interest page Sep 30, 2023
@suspect15
Copy link

No concern about Jr Devs seeing additional interest from the CR team. Per a recent vote, we are not permitting Jr Devs to collab until after the mentor program is stood up due to significant issues with recent collabs, but there's no reason they shouldn't be able to see developer interest.

@Jamiras Jamiras merged commit 514ea44 into RetroAchievements:master Oct 27, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants