fix: user created timestamp not cast to Carbon

app/Api/Middleware/LogApiUsage.php

@@ -15,7 +15,6 @@ public function handle(Request $request, Closure $next): mixed
         /** @var User $user */
         $user = $request->user('api-token');
 
-        $user->timestamps = false;
         $user->increment('APIUses');
 
         return $next($request);

app/Helpers/database/ticket.php

@@ -15,35 +15,36 @@
 use Illuminate\Support\Facades\Cache;
 use Illuminate\Support\Facades\DB;
 
-function isAllowedToSubmitTickets(string $user): bool
+function isAllowedToSubmitTickets(string $username): bool
 {
-    if (!isValidUsername($user)) {
+    if (!isValidUsername($username)) {
         return false;
     }
 
-    $cacheKey = CacheKey::buildUserCanTicketCacheKey($user);
+    $cacheKey = CacheKey::buildUserCanTicketCacheKey($username);
 
-    $value = Cache::get($cacheKey);
-    if ($value !== null) {
-        return $value;
+    if (Cache::has($cacheKey)) {
+        return Cache::get($cacheKey);
     }
 
-    $value = getUserActivityRange($user, $firstLogin, $lastLogin)
-        && time() - strtotime($firstLogin) > 86400 // 86400 seconds = 1 day
-        && getRecentlyPlayedGames($user, 0, 1, $userInfo)
+    $user = User::firstWhere('User', $username);
+    $isAllowed = $user->Created->diffInDays() > 1
+        && getRecentlyPlayedGames($username, 0, 1, $userInfo)
         && $userInfo[0]['GameID'];
 
-    if ($value) {
-        // if the user can create tickets, they should be able to create tickets forever
-        // more. expire once every 30 days so we can purge inactive users
-        Cache::put($cacheKey, $value, Carbon::now()->addDays(30));
-    } else {
-        // user can't create tickets, which means the account is less than a day old
-        // or has no games played. only cache the value for an hour
-        Cache::put($cacheKey, $value, Carbon::now()->addHour());
-    }
-
-    return $value;
+    Cache::put(
+        $cacheKey,
+        $isAllowed,
+        $isAllowed
+            // if the user can create tickets, they should be able to create tickets forever
+            // more. expire once every 30 days so we can purge inactive users
+            ? Carbon::now()->addDays(30)
+            // user can't create tickets, which means the account is less than a day old
+            // or has no games played. only cache the value for an hour
+            : Carbon::now()->addHour()
+    );
+
+    return $isAllowed;
 }
 
 function submitNewTicketsJSON(

app/Helpers/database/user-activity.php

@@ -90,7 +90,6 @@ function postActivity(string|User $userIn, int $type, ?int $data = null, ?int $d
     // update UserAccount
     $user->LastLogin = Carbon::now();
     $user->LastActivityID = $activity->ID;
-    $user->timestamps = false;
     $user->save();
 
     return true;

app/Helpers/database/user-auth.php

@@ -78,7 +78,6 @@ function authenticateForConnect(?string $username, ?string $pass = null, ?string
 
     // update appTokenExpiry
     $user->appTokenExpiry = Carbon::now()->clone()->addDays(14);
-    $user->timestamps = false;
     $user->save();
 
     postActivity($user, ActivityType::Login);
@@ -208,7 +207,6 @@ function authenticateFromCookie(
 
     // valid active account. update the last activity timestamp
     $user->LastLogin = Carbon::now();
-    $user->timestamps = false;
     $user->save();
 
     // validate permissions for the current page if required