Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only fetch claimants for set requests on set requests page #2038

Merged
merged 2 commits into from
Nov 19, 2023

Conversation

Jamiras
Copy link
Member

@Jamiras Jamiras commented Nov 18, 2023

eliminates a ~40ms query from my profile page

Copy link
Member

@wescopeland wescopeland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified locally.

Tangentially related: it seems kinda weird that on every page that doesn't have a set, we're making a client-side call to set-requests.php. We should probably consider refactoring this to live entirely on the server - the content being rendered from the response is causing a tiny layout shift because it isn't initially painted to the screen.

@Jamiras
Copy link
Member Author

Jamiras commented Nov 18, 2023

it seems kinda weird that on every page that doesn't have a set, we're making a client-side call to set-requests.php.

That logic has been there since it was introduced in #378. I assume it's a result of mimicking the set rating logic that's present when the game does have a set. That was eliminated in #960.

@wescopeland
Copy link
Member

Yep, not suggesting at all it was introduced by this PR or should even change in this PR. Just more of a note we should probably consider refactoring sometime soon-ish.

@Jamiras Jamiras merged commit 6e41e48 into RetroAchievements:master Nov 19, 2023
5 checks passed
@Jamiras Jamiras deleted the less_request_data branch November 19, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants