Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(livewire): enable the back button cache #2044

Merged
merged 3 commits into from
Nov 20, 2023

Conversation

wescopeland
Copy link
Member

@wescopeland wescopeland commented Nov 19, 2023

Fixes a performance regression introduced in V4.

Currently, the notification icon component is disabling the browser back/forward navigation cache due to a Livewire config setting. In other words, when pressing the back button (or, more probably, backswiping on mobile), the entire page must be re-requested even if nothing has changed. This ultimately results in more calls to the server, and those additional calls are often unnecessary.

This config change results in Livewire allowing the back/forward cache to be used again.

Unfortunately, there isn't a great way to test this PR locally because the local websocket listening for changes in order to trigger an auto-refresh also disables the bfcache.

@wescopeland wescopeland requested a review from a team November 19, 2023 18:39
@wescopeland wescopeland merged commit 20e683e into RetroAchievements:master Nov 20, 2023
5 checks passed
@wescopeland wescopeland deleted the livewire-bfcache branch November 20, 2023 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants