Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(game): adjust completion % rounding to match other pages #2057

Merged

Conversation

wescopeland
Copy link
Member

Resolves https://discord.com/channels/310192285306454017/1177243393735270532.

Currently, sometimes the progress component on game pages shows a different percentage than user pages. This is due to a difference in how the numbers are rounded.

Before
Screenshot 2023-11-24 at 10 21 18 AM

Screenshot 2023-11-24 at 10 21 24 AM

After
Screenshot 2023-11-24 at 10 22 12 AM

@wescopeland wescopeland requested a review from a team November 24, 2023 15:22
@wescopeland wescopeland merged commit b83f054 into RetroAchievements:master Nov 26, 2023
5 checks passed
@wescopeland wescopeland deleted the fix-game-completion-rounding branch November 26, 2023 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants