Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(game): unify softcore and progress styles with other pages #2060

Merged

Conversation

wescopeland
Copy link
Member

This PR adjusts some of the styles on the game page so softcore progress matches how it's displayed elsewhere on the site (eg: user profiles and the completion progress page). Right now on prod there is a discrepancy in how softcore progress is represented, which is fixed by this PR.

This is done by adjusting the colors on progress bars and the achievement distribution chart.

Before
Screenshot 2023-11-24 at 8 08 01 PM

Screenshot 2023-11-24 at 8 08 07 PM

After
Screenshot 2023-11-24 at 8 04 15 PM

Screenshot 2023-11-24 at 8 04 24 PM

@wescopeland wescopeland requested a review from a team November 25, 2023 01:09
Copy link
Member

@Jamiras Jamiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I understand the desire for the changes, I find it harder to see small sections of softcore bars. There's a lot less contrast between grey and yellow than blue and yellow.

Before:
image

After:
image

Also, there's still other places that need to be updated - Completion Progress on the profile page being the most obvious.

The Recent Progress/History graphs seem to be using blue for hardcore and grey for softcore, which aligns with the points shown in the upper right corner of the screen.

@wescopeland
Copy link
Member Author

I find it harder to see small sections of softcore bars. There's a lot less contrast between grey and yellow than blue and yellow.

I agree it is harder to see when the bars are this tiny. I've made a slight tweak on these bars to change the softcore color from neutral-500 to neutral-400/80. This raises the brightness ever so slightly.

Screenshot 2023-11-27 at 5 11 35 PM

Also, there's still other places that need to be updated - Completion Progress on the profile page being the most obvious.

Agreed. I wanted to tackle this in a separate PR as that component is complex enough that it needs a Blade rewrite.

@Jamiras
Copy link
Member

Jamiras commented Dec 1, 2023

I've made a slight tweak on these bars to change the softcore color from neutral-500 to neutral-400/80. This raises the brightness ever so slightly.

Raising the brightness actually lowers the contrast and makes it harder to separate the two colors.

neutral-500 is #737373.
image

neutral-400/80 is #848484:
image

At #606060, the bars are distinct:
image

Could also add a gap (which seems to be present in the Achievement Distribution graph). This is #848484 with a margin-left:1px gap:
image

Here's the "sliver" bar in each of the above styles:
image

What do you think about going back to neutral-500 and adding the gap?

@wescopeland
Copy link
Member Author

What do you think about going back to neutral-500 and adding the gap?

I like that idea. Done in latest.

Screenshot 2023-12-01 at 5 15 26 PM

@luchaos luchaos merged commit 95f90b3 into RetroAchievements:master Dec 3, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants