-
-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(game): unify softcore and progress styles with other pages #2060
feat(game): unify softcore and progress styles with other pages #2060
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While I understand the desire for the changes, I find it harder to see small sections of softcore bars. There's a lot less contrast between grey and yellow than blue and yellow.
Also, there's still other places that need to be updated - Completion Progress on the profile page being the most obvious.
The Recent Progress/History graphs seem to be using blue for hardcore and grey for softcore, which aligns with the points shown in the upper right corner of the screen.
I agree it is harder to see when the bars are this tiny. I've made a slight tweak on these bars to change the softcore color from neutral-500 to neutral-400/80. This raises the brightness ever so slightly.
Agreed. I wanted to tackle this in a separate PR as that component is complex enough that it needs a Blade rewrite. |
This PR adjusts some of the styles on the game page so softcore progress matches how it's displayed elsewhere on the site (eg: user profiles and the completion progress page). Right now on prod there is a discrepancy in how softcore progress is represented, which is fixed by this PR.
This is done by adjusting the colors on progress bars and the achievement distribution chart.
Before
After