Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow moderators to mute users #2300

Merged
merged 9 commits into from
Mar 28, 2024

Conversation

wescopeland
Copy link
Member

This PR leverages the existing UserAccounts.muted_until field and Folio user management panel to allow moderators to mute users.

When a user is muted, they will no longer be able to comment, post or edit on the forum, or send DMs.

To mute a user, visit http://localhost:64000/manage/users/[USERNAME_HERE]/edit. There is already a field to set the muted_until value:

Screenshot 2024-03-17 at 5 47 23 PM

Before
Screenshot 2024-03-17 at 5 44 37 PM

After
Screenshot 2024-03-17 at 5 44 23 PM

@wescopeland wescopeland requested a review from a team March 17, 2024 21:47
@televandalist
Copy link
Member

We're gonna need to pull the "admin comments" soon. Got a lot of catching up to do. ;)

@DawnBracken

This comment was marked as off-topic.

@RetroAchievements RetroAchievements locked and limited conversation to collaborators Mar 18, 2024
@luchaos
Copy link
Member

luchaos commented Mar 18, 2024

Minor detail: it's Filament instead of Folio ;)
Thanks for wiring it all up! ❤️

@wescopeland
Copy link
Member Author

Terminology confusion 😵‍💫, thank you for the correction!

Copy link
Member

@Jamiras Jamiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should private messages also be muted? I assume we'd want to at least allow messaging RAdmin.

app/Helpers/render/comment.php Show resolved Hide resolved
app/Helpers/database/user-auth.php Show resolved Hide resolved
resources/views/pages-legacy/viewtopic.blade.php Outdated Show resolved Hide resolved
@wescopeland
Copy link
Member Author

@Jamiras

Should private messages also be muted? I assume we'd want to at least allow messaging RAdmin.

My opinion is loosely held and I could be swayed otherwise, but I think private messages (including to RAdmin) should be muted. I assume this kind of action is going to be taken against a user who has already been warned to stop. Especially now that the UI will show when the mute will be lifted, once a user is muted I'm not sure there will actually be much more to substantiate on.

@Jamiras
Copy link
Member

Jamiras commented Mar 27, 2024

I've noticed that there's no way for a moderator to tell that a user is muted without looking directly at the database. The field appears empty when editing the account a subsequent time, and there's no audit trail.

Similarly, the muted_until field remains set even after the period has elapsed. The logic is still correct as it looks for times in the future, but it might be nice to clean that up after it's no longer needed.

@wescopeland
Copy link
Member Author

#2313

@wescopeland wescopeland merged commit 47f4962 into RetroAchievements:master Mar 28, 2024
5 checks passed
@wescopeland wescopeland deleted the ismuted-user-prop branch March 28, 2024 14:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants