Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(connect): add User type to allprogress query #2977

Closed

Conversation

drisc
Copy link
Contributor

@drisc drisc commented Dec 24, 2024

Reported by Stenzek, who would like to use it to get a list of all progress on Playstation games in Duckstation, allprogress in the connect api is currently broken due to a type error.

Current Error:
GetAllUserProgress(): Argument #1 ($user) must be of type App\\Models\\User, string given, called in dorequest.php on line 239

Fixed response (from my local instance):

{
    "Success": true,
    "Response": {
        "1": {
            "NumAch": 8,
            "Earned": "8",
            "HCEarned": "5"
        },
        "2": {
            "NumAch": 9,
            "Earned": "2",
            "HCEarned": "0"
        },
        "3": {
            "NumAch": 10,
            "Earned": "0",
            "HCEarned": "0"
        }
    }
}

Copy link
Member

@wescopeland wescopeland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This endpoint seems to have been offline for roughly 14 months. I'm happy to support it, but if we do then it needs to be covered by tests.

@drisc
Copy link
Contributor Author

drisc commented Jan 15, 2025

Closing as a better implementation can be found in #3062

@drisc drisc closed this Jan 15, 2025
@drisc drisc deleted the connectapi-allprogress-fix branch January 15, 2025 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants