feat(home): show user's current AOTW unlock status #3054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jamiras
reviewed
Jan 17, 2025
app/Http/Actions/CalculateAchievementOfTheWeekUserProgressAction.php
Outdated
Show resolved
Hide resolved
resources/js/features/home/components/+sidebar/AchievementOfTheWeek/AotwStreak/AotwStreak.tsx
Outdated
Show resolved
Hide resolved
Jamiras
approved these changes
Jan 18, 2025
|
|
||
| return ( | ||
| <div data-testid="aotw-progress" className="bg-neutral-950 px-2 py-1.5"> | ||
| <p className="text-center text-xs text-neutral-300">{t('Unlocked.')}</p> |
There was a problem hiding this comment.
I find the period here out of place. It's not a sentence.
There was a problem hiding this comment.
No problem, went ahead and removed the period.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a change to the home AOTW component to show the user's current status in the event. There are 4 cases that the new
<AotwStreak />component covers:Case 1: Non-participating user.
If the user is not participating in AOTW, they see what the component currently shows:
Case 2: User unlocked the AOTW.
If the user has just begun participating in AOTW and unlocked the current event achievement, they see an "Unlocked." message:
Case 3: User unlocked last week's AOTW, but not this week's.
The user will see a subtle call-to-action (CTA) to keep up their streak:
Case 4: User unlocked this week's AOTW and is continuing a streak.
The user sees their current streak count in the unlocked label: