-
-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(UnlockableAchievementAvatar): swap t()
for <Trans />
#3063
fix(UnlockableAchievementAvatar): swap t()
for <Trans />
#3063
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UnlockableAchievementAvatar
is currently only used by the achievement-checklist
(#3018).
The event page is handled here:
RAWeb/resources/views/components/game/achievements-list/achievements-list-item.blade.php
Line 84 in 1d49bb9
<span>from</span> |
And the event achievement is handled here (this one might be real tricky):
From: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved for achievement checklist. Did you have any thoughts on the event page or event achievement page?
There's probably not much we can do for localization on those pages until they're migrated to React. Finishing up ripping out hubs from game pages will be a big step towards migration of game pages. Once that's done, I plan on doing a phased conversion of game pages to React very similar to what happened with the home page. First, a PR just with UI components containing hardcoded values. Then, a PR to connect real data to the page. Then, subsequent PRs to stamp out all the ancillary things that come up (handling events, component edge cases, etc). |
Translators are reporting some trouble with the "from" string. This PR swaps
t('from')
with a<Trans />
string that has the achievement title and game title set to "sr-only". This should provide them with the context they need without causing any disruption on the page.Additionally, I implemented the TODO for showing the points in the title: