perf(site-award): query for game_sets in SeparateAwards() #3066
+52
−21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates
SeparateAwards()
to usegame_sets
instead ofGameAlternatives
.After #3065 is merged, to the best of my knowledge, this is the only place actually querying for
GameAlternatives
.While working on this function, I couldn't help but notice that
SeparateAwards()
is wildly inefficient. With the changes in this PR, I was able to drop the number of queries on at least one developer's user profile by ~40.This PR:
whereIn
.