Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent double transform of memref chain #392

Merged
merged 1 commit into from
Jan 18, 2025

Conversation

Jamiras
Copy link
Member

@Jamiras Jamiras commented Jan 11, 2025

The modified_memref chain for "bcd(X) + bcd(Y)" has already performed the BCD conversion, so the condition "bcd(Y) > N" should not apply the BCD transform again after reading the composite value.

@Jamiras Jamiras added this to the 11.7.0 milestone Jan 11, 2025
@Jamiras Jamiras merged commit 08999e0 into RetroAchievements:develop Jan 18, 2025
7 checks passed
@Jamiras Jamiras deleted the bugfix/double_transform branch January 18, 2025 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant