Always call readyForPromotedProduct on the main actor #4584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkVillacampa
approved these changes
Dec 12, 2024
fire-at-will
changed the title
This was referenced Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR is a potential fix for #4582. A customer is reporting occasional crashes when the
PurchaseDelegate'sreadyForPromotedProduct. The stacktraces indicate that this is happening in both SK1 & SK2 flows. My current theory is that we are calling thereadyForPromotedProductfunction on a background thread when the calling code expects it to be on the main actor/thread.Update: We heard back from the creator of the issue, and the code that their calling code is in a @mainactor class.
Description
This PR:
readyForPromotedProducton the main actorPurchaseDeferredPurchasesTestsandPurchaseDeferredPurchasesSK2Teststo wait for the callback to be completed since it's now called asynchronusly