Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add defaultLanguageText to feedbackSurveyCompleted callback #4625

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vegaro
Copy link
Contributor

@vegaro vegaro commented Dec 31, 2024

With the changes we did to the localization UI, this callback is kinda broken since the ids are auto-generated, and mean nothing to the developer.

After this PR we'll be sending the English translation of the option as well so it's easier to understand what each option represent. It requires backend changes to send the English/default language translation to the callback as well.

/// An option of the feedback survey has been selected
/// - Parameter feedbackSurveyOptionId: The id of the selected feedback survey option
/// - Parameter defaultLanguageText: The displayed text of the selected feedback survey option (in English)
case feedbackSurveyCompleted(_ feedbackSurveyOptionId: String, defaultLanguageText: String)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unsure about the name of hte parameter

@RevenueCat-Danger-Bot
Copy link

1 Error
🚫 Label the PR using one of the change type labels. If you are not sure which label to use, choose pr:other.
Label Description
pr:feat A new feature. Use along with pr:breaking to force a major release.
pr:fix A bug fix. Use along with pr:force_minor to force a minor release.
pr:other Other changes. Catch-all for anything that doesn't fit the above categories. Releases that only contain this label will not be released. Use along with pr:force_patch, or pr:force_minor to force a patch or minor release.
pr:RevenueCatUI Use along any other tag to mark a PR that only contains RevenueCatUI changes
pr:next_release Preparing a new release
pr:dependencies Updating a dependency
pr:phc_dependencies Updating purchases-hybrid-common dependency

Generated by 🚫 Danger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants