Fix local rsync issues

[ferki]

This PR fixes #1370 by testing for, and fixing the following issues around local rsync operations:

• if {download => 1} is in effect, don't prefix source with user@servername:
• servername for local connections inside tasks is <local>, so check for that too

I open this PR as draft as it most probably needs some clean up (changelog, wording, also more general testing approach for the various options) before merging.

Checklist

• based on top of latest source code
• changelog entry included
• tests pass on Travis CI
• git history is clean
• git commit messages are well-written

[sdondley]

Tested manually and it works. I also ran dzil test locally and all tests passed.

Thanks!

[ferki]

Tested manually and it works. I also ran dzil test locally and all tests passed.

Great, thanks for the feedback! I'll try to include it in a last trial release before 1.12.0 later today.

[sdondley]

Any chance you can look at #1356?

[ferki]

Any chance you can look at #1356?

That's a different story and context. At the moment, I don't expect that I'll be able to handle that before the next release.