Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shell.pm: add iDRAC 4.00.00.00 support #1469

Closed
wants to merge 1 commit into from

Conversation

alip
Copy link
Contributor

@alip alip commented Feb 12, 2021

This PR is an attempt to fix # by .

Checklist

  • based on top of latest source code
  • changelog entry included
  • tests pass on Travis CI
  • git history is clean
  • git commit messages are well-written

@alip alip mentioned this pull request Feb 12, 2021
Copy link
Member

@ferki ferki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this can be handled pretty much the same way as #1468:

  • fix the copyright
  • publish module on CPAN
  • include the mapping upstream

edit: actually, this might also need to be formatted with perltidy

@alip alip force-pushed the upstream-idrac-4-support branch from 0e0711c to b66481a Compare February 23, 2021 12:23
@alip
Copy link
Contributor Author

alip commented Feb 23, 2021

Thank you for the feedback. I have updated this PR to only include the mapping and created a git repository to host the module here where I fixed the copyright and formatted the code with perltidy. @ferki, would you please be so kind to take a quick look at the aforementioned repository before I make a release to see if it looks good? Thank you.

@ferki ferki mentioned this pull request Feb 24, 2021
5 tasks
@ferki
Copy link
Member

ferki commented Mar 13, 2021

As briefly discussed via IRC earlier, I'm closing this one in favor of discussing a more complete solution via #1481.

@ferki ferki closed this Mar 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants